Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Repo internal links from exercises/solutions are broken #3

Closed
letientai299 opened this issue Mar 9, 2017 · 3 comments
Closed

Repo internal links from exercises/solutions are broken #3

letientai299 opened this issue Mar 9, 2017 · 3 comments
Labels

Comments

@letientai299
Copy link

It seems that you have changed repo name from system-design-primer-interview to system-design-primer, while using hard link (https://github.com/donnemartin/...) inside the readmes.

I suggest to user Github relative link schema instead.

@donnemartin
Copy link
Owner

Hi @letientai299, it looks like the links for the exercises/solutions are broken, I'll fix them. Thanks for reporting!

@donnemartin donnemartin added the bug label Mar 9, 2017
@letientai299
Copy link
Author

FYI, you can replace

https://github.com/donnemartin/system-design-primer-interview#index-of-system-design-topics-1

with

/README.md#index-of-system-design-topics-1

@donnemartin
Copy link
Owner

@letientai299 I fixed the broken links as the first pass. I missed your tip, we can make them relative in the next pass. I've opened up #6 to keep track.

Thanks!

@donnemartin donnemartin changed the title Repo internal links are broken Repo internal links from exercises/solutions are broken Mar 9, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants