-
Notifications
You must be signed in to change notification settings - Fork 32
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[FloatingActionButton] implementing floatingActionButton component #63
Comments
I think it's similar to IconButton component. |
Assigned 🚀 |
@wndudqus <Floating {...props}>
<Button onClick={...}>
</Floating> or for the feature 3, <Floating
{...props}
main={<Button onClick-{...}/>}
sub={[<IconButton name='abc'/>, <IconButon name='bcd'/>]}
> How do you think? I'm looking forward to your work. 😄 |
@yujong-lee |
@yujong-lee I just want to point out DRY for same elements in |
If someone wants to support custom element in specifix index, it can be provided like below.
Just my idea 😉 |
I think you meant this. <FAB
renderItems={(item, i) => {
if (i === 3) return <MyView />;
return item;//return original Component
}
...
/> Did I get it right? |
Thanks for sharing your thought! Yes. repeating is bad practice. But I think repeating doesn't matter here because I can always remove it using function returning array of components. (for simple case So now, I think the key is how |
The Also, not only |
I created PR about this issue. If you have some time please check it out. |
Resolved with #67. |
Floating action button(FAB) is a very common component in touch based devices.
material design
There are many libraries that supports floating action button, and it is good for highlights the most important action on the page.
I think we should support FAB.
I'm proposing FAB that has the following features:
The text was updated successfully, but these errors were encountered: