Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Function "remove" in class "EventList<T>" return not correct #209

Closed
tdinhv opened this issue Mar 12, 2020 · 1 comment
Closed

Function "remove" in class "EventList<T>" return not correct #209

tdinhv opened this issue Mar 12, 2020 · 1 comment

Comments

@tdinhv
Copy link

tdinhv commented Mar 12, 2020

Version of flutter_calendar_carousel

1.4.11

Expected behavior

Result is false

Actual behavior

Result is true

flutter doctor result (run flutter doctor in terminal)

Steps to reproduce the behavior

bool remove(DateTime date, T event) {
    return events != null && events.containsKey(date)
        ? events[date].remove(event)
        : true;
  }

In this func, i think if events.containsKey(date) == false it should return false.
EX:

   bool remove(DateTime date, T event) {
    return events != null && events.containsKey(date)
        ? events[date].remove(event)
        : false;
  }
@hyochan
Copy link
Member

hyochan commented Mar 25, 2020

Would you like to give a PR for this?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants