Skip to content
This repository has been archived by the owner on May 31, 2021. It is now read-only.

Add AutoComplete C. Story #67

Merged
merged 4 commits into from Dec 8, 2019
Merged

Add AutoComplete C. Story #67

merged 4 commits into from Dec 8, 2019

Conversation

jb9229
Copy link

@jb9229 jb9229 commented Dec 8, 2019

  • add addon-ondevice-knobs D.

Description

I added a new 'Auto Complete Story'.
This is not perfect right now, because the implementation is not yet complete.
But I believe it's a good starting point.

Related Issues

#50

Tests

It is a development utility that does not require testing.

Checklist

Before you create this PR confirms that it meets all requirements listed below by checking the relevant checkboxes ([x]). This will ensure a smooth and quick review process.

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I signed the [CLA].
  • Run yarn test or yarn test -u if you need to update snapshot.
  • Run yarn lint
  • I am willing to follow-up on review comments in a timely manner.

@codecov
Copy link

codecov bot commented Dec 8, 2019

Codecov Report

Merging #67 into feat/autoComplete will not change coverage.
The diff coverage is n/a.

@@                Coverage Diff                 @@
##           feat/autoComplete      #67   +/-   ##
==================================================
  Coverage              80.52%   80.52%           
==================================================
  Files                      8        8           
  Lines                    190      190           
  Branches                  45       45           
==================================================
  Hits                     153      153           
  Misses                    24       24           
  Partials                  13       13

  - Add Wrapper Style change to Object from height number
Copy link
Contributor

@marsinearth marsinearth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! great work. I'll merge it and modify a little bit of Wrapper style on autoComplete storybook, and revert STORYBOOK_START back to true on App.js of the root directory.

@marsinearth marsinearth merged commit 6055cda into hyochan:feat/autoComplete Dec 8, 2019
hmhm2292 pushed a commit to hmhm2292/dooboo-ui-native that referenced this pull request Dec 15, 2019
* Add AutoComplete C. Story
  - add addon-ondevice-knobs D.

* Update Doc/AutoComplete/ Add Storybook in Readme

* Fix/AutoComplete/ lint error fixed

* Update/AutoComplete Storybook/ Wrapper Style

  - Add Wrapper Style change to Object from height number
hmhm2292 pushed a commit to hmhm2292/dooboo-ui-native that referenced this pull request Dec 15, 2019
* Add AutoComplete C. Story
  - add addon-ondevice-knobs D.

* Update Doc/AutoComplete/ Add Storybook in Readme

* Fix/AutoComplete/ lint error fixed

* Update/AutoComplete Storybook/ Wrapper Style

  - Add Wrapper Style change to Object from height number
hmhm2292 pushed a commit to hmhm2292/dooboo-ui-native that referenced this pull request Dec 18, 2019
* Add AutoComplete C. Story
  - add addon-ondevice-knobs D.

* Update Doc/AutoComplete/ Add Storybook in Readme

* Fix/AutoComplete/ lint error fixed

* Update/AutoComplete Storybook/ Wrapper Style

  - Add Wrapper Style change to Object from height number
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants