Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Document] Wrote a document for FAB. #141

Merged
merged 2 commits into from Oct 6, 2021

Conversation

Juyeong-Byeon
Copy link
Contributor

Description

I wrote a document for FAB.
I explained the definition of FAB and interface.

스크린샷 2021-10-06 오후 11 45 47

Test Plan

none

Related Issues

Related Issues

Tests

none

Checklist

Before you create this PR confirms that it meets all requirements listed below by checking the relevant checkboxes ([x]). This will ensure a smooth and quick review process.

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • Run yarn test:all and make sure nothing fails. You can run yarn test -u to update snapshots if needed.
  • I am willing to follow-up on review comments in a timely manner.

1. add story for FAB button in doc project
2. add basic introduction  doc for FAB
@Juyeong-Byeon Juyeong-Byeon mentioned this pull request Oct 6, 2021
3 tasks
@codecov
Copy link

codecov bot commented Oct 6, 2021

Codecov Report

Merging #141 (770edcd) into master (8c40090) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master     #141   +/-   ##
=======================================
  Coverage   94.59%   94.59%           
=======================================
  Files          27       27           
  Lines         648      648           
  Branches      283      283           
=======================================
  Hits          613      613           
  Misses         34       34           
  Partials        1        1           

add Demo
@Juyeong-Byeon
Copy link
Contributor Author

@hyochan @yujong-lee
I wrote a document for FAB.
check plz.

@yujonglee yujonglee self-requested a review October 6, 2021 18:11
@yujonglee yujonglee added the 📖 documentation Improvements or additions to documentation label Oct 6, 2021
Copy link
Contributor

@yujonglee yujonglee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work! 👍

@yujonglee yujonglee closed this Oct 6, 2021
@yujonglee yujonglee reopened this Oct 6, 2021
@yujonglee yujonglee merged commit 8d0de13 into dooboolab-community:master Oct 6, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
📖 documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants