Add hover style for [Selectbox] #144
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #144 +/- ##
==========================================
+ Coverage 94.59% 94.63% +0.03%
==========================================
Files 27 27
Lines 648 652 +4
Branches 283 285 +2
==========================================
+ Hits 613 617 +4
- Misses 34 35 +1
+ Partials 1 0 -1 |
|
@yujong-lee @hyochan |
yujonglee
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
add hover style for selectbox
Description
add hover style for selectbox.
hover feedback is Important in Web environment.
Without hover style, user can't know Intuitively which item will be chosen.
before:
https://user-images.githubusercontent.com/35381940/136384096-021608fa-e6c2-4276-9476-44f0b3356013.mov
after:
https://user-images.githubusercontent.com/35381940/136384210-c6ad768d-0c5a-41c8-8962-1178829b35fc.mov
And I added the props that can used for customizing the hover style
Test Plan
none
Related Issues
none
Tests
I added the following tests:
check out web demo
Checklist
Before you create this PR confirms that it meets all requirements listed below by checking the relevant checkboxes (
[x]). This will ensure a smooth and quick review process.yarn test:alland make sure nothing fails. You can runyarn test -uto update snapshots if needed.