Fix the dark mode release from iOS background #162
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
I modified the release of dark mode in iOS background.
This is a bug in the addChangeListener, a method of the Appearance in react-native.
This is a bug that only happens in iOS. Issue link
Despite the dark theme, the color Scheme variable is initialized to light when switching to background.
To solve this problem, I changed it to match the color by calling Appearance.getColorScheme() again when the listener is called.
Before
bug.mov
After
fix.mov
Test Plan
N/A
Related Issues
N/A
Tests
N/A
Checklist
Before you create this PR confirms that it meets all requirements listed below by checking the relevant checkboxes (
[x]
). This will ensure a smooth and quick review process.yarn test:all
and make sure nothing fails. You can runyarn test -u
to update snapshots if needed.