Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: [CheckboxStory] responsive layout #61

Merged

Conversation

Juyeong-Byeon
Copy link
Contributor

@Juyeong-Byeon Juyeong-Byeon commented Aug 9, 2021

Description

I found a small style problem in checkboxStory Component and fixed it.

Before:

  1. There is no flexWrap option in Wrapper component so in mobile environment some checkbox won't show
  2. There is no key props for LabelWrapper, so there are warnings while compiling code

KakaoTalk_Photo_2021-08-09-22-16-35

After:

  1. Added flexWrap:'wrap' and justifyContent:'center' for responsive layout
  2. Added key props for LabelWrapper

KakaoTalk_Photo_2021-08-09-22-16-18

Related Issues

X

Tests

X

Checklist

Before you create this PR confirms that it meets all requirements listed below by checking the relevant checkboxes ([x]). This will ensure a smooth and quick review process.

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • Run yarn test or yarn test -u if you need to update snapshot.
  • Run yarn lint
  • I am willing to follow-up on review comments in a timely manner.

before:
1. there is no flexWrap option in Wrapper Component so in mobile environment some checkbox won't show
2. there is no key props for LabelWrapper, so there are warnings while compiling code

after:

1. added flexWrap:'wrap' and justifyContent:'center' for responsive layout
2. added key props for LabelWrapper
@codecov
Copy link

codecov bot commented Aug 9, 2021

Codecov Report

Merging #61 (4df40c6) into master (ab9bf3f) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master      #61   +/-   ##
=======================================
  Coverage   93.94%   93.94%           
=======================================
  Files          21       21           
  Lines         545      545           
  Branches      236      236           
=======================================
  Hits          512      512           
  Misses         33       33           

@hyochan hyochan added 🍗 enhancement New feature or request 📖 documentation Improvements or additions to documentation labels Aug 9, 2021
Copy link
Member

@hyochan hyochan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@hyochan hyochan merged commit 63175fd into dooboolab-community:master Aug 9, 2021
@yujonglee yujonglee mentioned this pull request Aug 20, 2021
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
📖 documentation Improvements or additions to documentation 🍗 enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants