Replace style props to styles in [Accordion] #69
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
All components in dooboo-ui should follow this pattern.
Codecov Report
@@ Coverage Diff @@
## master #69 +/- ##
==========================================
+ Coverage 95.37% 95.39% +0.01%
==========================================
Files 21 21
Lines 541 543 +2
Branches 232 234 +2
==========================================
+ Hits 516 518 +2
Misses 25 25 |
hyochan
reviewed
Aug 17, 2021
hyochan
requested changes
Aug 17, 2021
| renderTitle?: (item: string) => React.ReactElement; | ||
| renderBody?: (item: string) => React.ReactElement; | ||
| } | ||
|
|
There was a problem hiding this comment.
Why did you insert interface on this code?
how did you plan to show it?
There was a problem hiding this comment.
It's my mistake. You can open a PR for this. Thanks for point it out.
luke-hanwook
added a commit
to luke-hanwook/dooboo-ui
that referenced
this pull request
Aug 27, 2021
Interface type is unnecessary code in docs I got a confirmation from below conversation https://github.com/dooboolab/dooboo-ui/pull/69/files/7bc93125c25e190aa8f9b2066d666e4565ac0512#r697234481 related PR dooboolab-community#69
4 tasks
hyochan
pushed a commit
that referenced
this pull request
Aug 28, 2021
Interface type is unnecessary code in docs I got a confirmation from below conversation https://github.com/dooboolab/dooboo-ui/pull/69/files/7bc93125c25e190aa8f9b2066d666e4565ac0512#r697234481 related PR #69 * Update legacy props in usage example for [Accordion] component - isAnimated -> shouldAnimate
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Wrap additional style props with
stylesobject.All components in dooboo-ui should follow this pattern.
Related Issues
none.
Tests
none.
Checklist
yarn testoryarn test -uif you need to update snapshot.yarn lint