Calendar should have default height to wrap content

[suesitran]

Version of flutter_calendar_carousel

Version 1.3.7

Expected behavior

CalendarCarousel widget should have wrap_content height if height attribute is not manually set

Actual behavior

when height is not set, CalendarCarousel takes full screen height

flutter doctor result (run flutter doctor in terminal)

Doctor summary (to see all details, run flutter doctor -v):
[✓] Flutter (Channel beta, v1.0.0, on Mac OS X 10.13.6 17G4015, locale en-AU)
[✓] Android toolchain - develop for Android devices (Android SDK 28.0.3)
[✓] iOS toolchain - develop for iOS devices (Xcode 10.1)
[✓] Android Studio (version 3.2)
[✓] Connected device (2 available)

• No issues found!

[hyochan]

@suesitran I think this should be expected because if you look in the source, this is taking height factor value to set up the calendar widget. It should have an explicit height to correctly size the calendar.

[suesitran]

@hyochan I think i should set this as feature request :) because without width/height value, i'm expecting the calendar widget to create the view which take exact space it needs for its view, regardless if the month has 4 weeks or 5 weeks, it'll always assume that the month has 5 weeks, so the height will be adjusted to cover just enough 5 weeks calendar, and default value for width is that it'll cover just enough for 7 days.

[aqibgatoo]

I think this is much needed because for months with less weeks it shows empty space ..which make the whole ui bad ..the it should have wrap height which prevents creation of empty spaces.

[suztomo]

I encountered this need when I was testing the proper height value. For iOS, height: 290 works fine. When I tried with iPad, the height 290 is too small.

Screenshots

iPhone 8

iPad

Workaround

I can implement workaround to adjust the height value depending on the display,