Null safety improvements #272
Conversation
Allow customDayBuilder and markedDateIconBuilder to return null. If it returns null, use the default. This restores the original behavior from v1. Fixes dooboolab-community#270.
|
Hey @IchordeDionysos and @hyochan. You seems to have been active with the null safety work, are you able to review and/or merge this change? |
lib/flutter_calendar_carousel.dart
Outdated
| @@ -1136,24 +1142,32 @@ class _CalendarState<T extends EventInterface> | |||
| bool isNextMonthDay, | |||
| bool isThisMonthDay, | |||
| DateTime now) { | |||
| final customDayBuilder = widget.customDayBuilder; | |||
| final customDayBuilder = this.widget.customDayBuilder; | |||
There was a problem hiding this comment.
Because a variable named widget exists in the same scope (even if declared later). It won't compile unless explicitly referenced through this.
There was a problem hiding this comment.
Writing this inside the stateful widget looks a bit awkward here. How about changing the above variable name to something else?
There was a problem hiding this comment.
It's the same to me, it is all within a small method. Should I change Widget widget to Widget tmp and remove the this prefix? I see tmp is used in other places.
There was a problem hiding this comment.
I went with dayContainer, it matches the method name and what it is trying to create.
Anything else I can fix with this?
Allow customDayBuilder and markedDateIconBuilder to return null. If it
returns null, use the default. This restores the original behavior from
v1. Fixes #260.