Fatal Exception: java.lang.IllegalStateException: Reply already submitted #339

offline-first · 2021-12-08T11:16:20Z

I got the error from Firebase Crashlytics. Are there any insights into this? Is this related to #336 @mgonzalezc ?

Fatal Exception: java.lang.IllegalStateException: Reply already submitted
       at io.flutter.embedding.engine.dart.DartMessenger$Reply.reply(DartMessenger.java:35)
       at io.flutter.plugin.common.MethodChannel$IncomingMethodCallHandler$1.success(MethodChannel.java:14)
       at com.dooboolab.flutterinapppurchase.MethodResultWrapper$1.run(MethodResultWrapper.java:8)
       at android.os.Handler.handleCallback(Handler.java:873)
       at android.os.Handler.dispatchMessage(Handler.java:99)
       at android.os.Looper.loop(Looper.java:214)
       at android.app.ActivityThread.main(ActivityThread.java:6990)
       at java.lang.reflect.Method.invoke(Method.java)
       at com.android.internal.os.RuntimeInit$MethodAndArgsCaller.run(RuntimeInit.java:493)
       at com.android.internal.os.ZygoteInit.main(ZygoteInit.java:1445)

Crash on: Android 9, Galaxy Note9 (real device)

flutter_inapp_purchase: ^5.1.2
flutter stable channel: 2.5.3
Android build-tools 31.0.0

The text was updated successfully, but these errors were encountered:

mgonzalezc · 2021-12-08T11:30:48Z

Hello! yes, it is

I have ended up using version 5.0.4. The crash isn't there for this version

I think the issue is related to the new handlers in MethodResultWrapper.java, added in #328. From what I could investigate, when getPurchaseHistory is called, the channel receives result.success twice. This is not allowed and that's why "Reply already submitted" fires.

My PR #336 helps a bit because it makes the calls under getPurchaseHistory asynchronous but if you call it several times in your code (for example, with a retry strategy when there is no connection) then the exception is fired as well.

offline-first · 2021-12-08T13:02:42Z

Hello @mgonzalezc
Thank you for the clarification. I think your PR fix the issue in my case

offline-first · 2021-12-09T18:47:46Z

Ok the problem still exists. I have downgraded to version 5.0.4

xalikoutis · 2021-12-10T10:32:13Z

me too downgraded back to flutter_inapp_purchase: 5.0.3

0x-cell · 2021-12-20T19:17:14Z

I've updated firebase to the latest version, and same error is occurring on flutter_inapp_purchase: ^5.0.2

  firebase_core: ^1.10.6
  firebase_crashlytics: ^2.4.4
  firebase_messaging: ^11.2.4

It seems that I've found a problem.
The AndroidInappPurchasePlugin.java#onMethodCall invokes several async operations on the billingClient. while persisting the safeResult in scope of the entire AndroidInappPurchasePlugin instance instead of per onMethodCall call. This creates a possibility of having several async tasks call the same instance of safeResult instead of the instance of safeResult bound to the corresponding onMethodCall cycle.

What i did to fix that was to change the

safeResult = new MethodResultWrapper(result, channel);

to

final MethodResultWrapper safeResult = new MethodResultWrapper(result, channel);
safeChannel = safeResult;

in the AndroidInappPurchasePlugin.java#onMethodCall. Note the safeChannel - it is used in private PurchasesUpdatedListener purchasesUpdatedListener = new PurchasesUpdatedListener() { instead of safeResult as it calls the channel anyways.

Back to drinking. Bye.

jesselpereira · 2022-02-02T02:04:23Z

Same here.

hmarat · 2022-02-10T15:07:48Z

@jesselpereira I have the same problem :( Did you solve it ??

jesselpereira · 2022-02-10T15:51:33Z

@jesselpereira I have the same problem :( Did you solve it ??

Hi dude, I just abandoned that package, migrated to in_app_purchase and solved my problems.

hmarat · 2022-02-10T19:56:46Z

@jesselpereira okay, thank you for answer :) So in that package it will automatically detect call update purchase callback on app open?))

jesselpereira · 2022-02-10T20:04:17Z

I believe it is worth trying to do this. In my project I have a callback when a purchase is completed, but I don't check it when I open the app. But this is an option that fits my project, nothing prevents you from implementing the package in your project. I believe this package here has been deprecated, or it's not a recognized flaw.

jorgevvr · 2022-02-10T20:46:54Z

Hello, I got the error on v5.0.4, v5.1.0, v5.1.1 and v5.1.2.
Works on v5.0.3
Please check this, and thank you for the great package.

giladger · 2022-03-15T14:28:25Z

Hi,
Any updates on this issue?
It suddenly started happening to me after upgrading to flutter 2.10

reju1021 · 2022-03-20T15:37:03Z

I've updated firebase to the latest version, and same error is occurring on flutter_inapp_purchase: ^5.0.2
  firebase_core: ^1.10.6
  firebase_crashlytics: ^2.4.4
  firebase_messaging: ^11.2.4
It seems that I've found a problem. The AndroidInappPurchasePlugin.java#onMethodCall invokes several async operations on the billingClient. while persisting the safeResult in scope of the entire AndroidInappPurchasePlugin instance instead of per onMethodCall call. This creates a possibility of having several async tasks call the same instance of safeResult instead of the instance of safeResult bound to the corresponding onMethodCall cycle.

What i did to fix that was to change the
safeResult = new MethodResultWrapper(result, channel);
to
final MethodResultWrapper safeResult = new MethodResultWrapper(result, channel);
safeChannel = safeResult;
in the AndroidInappPurchasePlugin.java#onMethodCall. Note the safeChannel - it is used in private PurchasesUpdatedListener purchasesUpdatedListener = new PurchasesUpdatedListener() { instead of safeResult as it calls the channel anyways.

Back to drinking. Bye.

Worked like a charm :)

giladger · 2022-03-23T08:33:52Z

@reju1021 @0x-cell can you please share a patch/open a PR?

Thanks!

valterh4ck3r · 2022-04-27T13:55:19Z

Hello Guys.

Use my library with fix

https://github.com/valterh4ck3r/flutter_inapp_purchase

My fix: #356

Use this dependency on pubspec.yaml

  flutter_inapp_purchase:
    git: https://github.com/valterh4ck3r/flutter_inapp_purchase

jesselpereira · 2022-04-27T16:26:10Z

Hello Guys.

Use my library with fix

https://github.com/valterh4ck3r/flutter_inapp_purchase

My fix: #356

Use this dependency on pubspec.yaml
  flutter_inapp_purchase:
    git: https://github.com/valterh4ck3r/flutter_inapp_purchase

Pls pull request your changes. 👏🏻

valterh4ck3r · 2022-04-27T16:39:53Z

Created Pull Request

#357

Vakil-Parth · 2022-04-28T06:17:48Z

Hello Guys.
Use my library with fix
https://github.com/valterh4ck3r/flutter_inapp_purchase
My fix: #356
Use this dependency on pubspec.yaml
  flutter_inapp_purchase:
    git: https://github.com/valterh4ck3r/flutter_inapp_purchase
Pls pull request your changes. 👏🏻

This didn't work for me.

still facing java.lang.IllegalStateException: Reply already submitted

when I call FlutterInappPurchase.instance.getAvailablePurchases() in android

offline-first · 2022-05-11T12:19:14Z

@valterh4ck3r
Unfortunately the error is still present.
Probably you have to make a purchase first and then call getAvailablePurchases()

valterh4ck3r · 2022-05-11T12:59:43Z

This error happens when flutter calls 2 functions at the same time.

The method call cannot respond at the same time with success or error results, so I've re-implemented the service to not make 2 calls at the same time.

Anyone with the same fix?

offline-first · 2022-05-11T13:33:14Z

@valterh4ck3r

You have it. Please change the part then it will work

Future<List<PurchasedItem>?> getPurchaseHistory() async {
    if (_platform.isAndroid) {
      final inappPurchaseHistory = await _channel.invokeMethod(
        'getPurchaseHistoryByType',
        <String, dynamic>{
          'type': describeEnum(_TypeInApp.inapp),
        },
      );

     final subsPurchaseHistory = await _channel.invokeMethod(
        'getPurchaseHistoryByType',
        <String, dynamic>{
          'type': describeEnum(_TypeInApp.subs),
        },
      );

      return extractPurchased(inappPurchaseHistory)! + extractPurchased(subsPurchaseHistory)!;
    } else if (_platform.isIOS) {
      dynamic result = await _channel.invokeMethod('getAvailableItems');

      return extractPurchased(json.encode(result));
    }
    throw PlatformException(
        code: _platform.operatingSystem, message: "platform not supported");
  }

valterh4ck3r · 2022-05-11T18:26:42Z

Wait for 1 second, before call method channel again.

Future<List<PurchasedItem>?> getPurchaseHistory() async {
    if (_platform.isAndroid) {
      final inappPurchaseHistory = await _channel.invokeMethod(
        'getPurchaseHistoryByType',
        <String, dynamic>{
          'type': describeEnum(_TypeInApp.inapp),
        },
      );

   await Future.delayed(Duration(seconds: 1) , (){});

     final subsPurchaseHistory = await _channel.invokeMethod(
        'getPurchaseHistoryByType',
        <String, dynamic>{
          'type': describeEnum(_TypeInApp.subs),
        },
      );

      return extractPurchased(inappPurchaseHistory)! + extractPurchased(subsPurchaseHistory)!;
    } else if (_platform.isIOS) {
      dynamic result = await _channel.invokeMethod('getAvailableItems');

      return extractPurchased(json.encode(result));
    }
    throw PlatformException(
        code: _platform.operatingSystem, message: "platform not supported");
  }

offline-first · 2022-05-11T18:39:05Z

The main problem is this line of code

List<dynamic> results = await Future.wait([getInappPurchaseHistory, getSubsPurchaseHistory]);

because the calls are sent in parallel and not in a queue. The timeout of one second is not needed in my test environment. But your fix in Java Source seems to need it too. Can you make a new pull request with my fix which I posted above?

valterh4ck3r · 2022-05-11T19:16:20Z

Yeah, it's perfect.

I will make new pull request, thank you so much @offline-first

valterh4ck3r · 2022-05-11T19:24:01Z

Done.

soarescaique · 2022-05-16T00:50:06Z

@valterh4ck3r @offline-first Any updates on this? I am still facing the same error on version 5.1.2.

offline-first · 2022-05-16T08:53:40Z

@valterh4ck3r please use my fix for the async issue!

valterh4ck3r · 2022-05-16T17:06:45Z

@offline-first can you send PR with your fix to repo ?

I can merge into my repo too.

offline-first · 2022-05-16T17:17:09Z

@valterh4ck3r done

valterh4ck3r · 2022-05-16T17:28:23Z

Thank you so much

valterh4ck3r · 2022-05-16T17:31:52Z

@offline-first merged.

soarescaique · 2022-05-16T17:48:07Z

@valterh4ck3r @offline-first Sorry if I am getting it wrong. But why was the PR #359 closed since it has already been approved to be merged by @hyochan. Thank you guys for the collaboration on the package.

hyochan · 2022-05-16T17:52:01Z

I think @valterh4ck3r has trouble managing the branch. I'll open up the PR again since it looks like the latest commit was intended.

hyochan · 2022-05-16T18:01:37Z

Closes due to #360

Released in 5.2.0

offline-first · 2022-05-16T19:13:23Z

Thanks @hyochan, purchase history is now works correctly again on android

mgonzalezc mentioned this issue Feb 14, 2022

Run on UiThread and few others #328

Merged

valterh4ck3r mentioned this issue Apr 27, 2022

Fix issue #339 #357

Closed

hyochan mentioned this issue May 16, 2022

Bugfix #339 #360

Merged

offline-first closed this as completed May 16, 2022

Fatal Exception: java.lang.IllegalStateException: Reply already submitted #339

Fatal Exception: java.lang.IllegalStateException: Reply already submitted #339

Comments

offline-first commented Dec 8, 2021

Crash on: Android 9, Galaxy Note9 (real device)

mgonzalezc commented Dec 8, 2021

offline-first commented Dec 8, 2021

offline-first commented Dec 9, 2021

xalikoutis commented Dec 10, 2021

0x-cell commented Dec 20, 2021 • edited

jesselpereira commented Feb 2, 2022

hmarat commented Feb 10, 2022

jesselpereira commented Feb 10, 2022

hmarat commented Feb 10, 2022

jesselpereira commented Feb 10, 2022

jorgevvr commented Feb 10, 2022

giladger commented Mar 15, 2022

reju1021 commented Mar 20, 2022

giladger commented Mar 23, 2022

valterh4ck3r commented Apr 27, 2022

jesselpereira commented Apr 27, 2022

valterh4ck3r commented Apr 27, 2022

Vakil-Parth commented Apr 28, 2022

offline-first commented May 11, 2022

valterh4ck3r commented May 11, 2022

offline-first commented May 11, 2022

valterh4ck3r commented May 11, 2022

offline-first commented May 11, 2022

valterh4ck3r commented May 11, 2022

valterh4ck3r commented May 11, 2022

soarescaique commented May 16, 2022

offline-first commented May 16, 2022

valterh4ck3r commented May 16, 2022

offline-first commented May 16, 2022

valterh4ck3r commented May 16, 2022

valterh4ck3r commented May 16, 2022

soarescaique commented May 16, 2022

hyochan commented May 16, 2022

hyochan commented May 16, 2022

offline-first commented May 16, 2022

0x-cell commented Dec 20, 2021 •

edited