Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#116 changed Future<Null> to Future due to dart sdk change #117

Merged
merged 1 commit into from Oct 29, 2019
Merged

#116 changed Future<Null> to Future due to dart sdk change #117

merged 1 commit into from Oct 29, 2019

Conversation

Jon-Salmon
Copy link
Contributor

I believe this is the only change required for compatibility with Flutter v1.10 and higher.

Please check that this doesn't break anything I have missed, I have only tested with a single in-app-purchase and run the tests.

Copy link
Member

@hyochan hyochan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the fixes. If I remember correctly, the Future method required generic type to be passed and the Null was safer than the void (correct me if I am wrong).

Let's have a go with this fix and see how others use it.

@hyochan hyochan merged commit 7f00692 into dooboolab-community:master Oct 29, 2019
@Jon-Salmon
Copy link
Contributor Author

I believe up until now Future<Null> would be handled as if it was Future<dynamic> but this has now changed.

I guess the best solution from a readability point of view would be to use Future<dynamic> but this wouldn't effect the code running as it is identical to just using Future

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bugfix enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants