Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

setAudioMeterToAmbient #252

Conversation

lukepighetti
Copy link

@lukepighetti lukepighetti commented Mar 25, 2020

This allows the package consumer to immediately set the audio meter to ambient, iOS only implementation so far.

Addresses #251

Apologies for the large diff, I didn't know this package wasn't using dartfmt

@Larpoux
Copy link
Collaborator

Larpoux commented Mar 25, 2020

This pull request seems interesting.
But I wonder what to do for Android ?

@hyochan
Copy link
Collaborator

hyochan commented Mar 25, 2020

@lukepighetti Same question as @Larpoux

@lukepighetti
Copy link
Author

lukepighetti commented Mar 26, 2020

If I'm being honest I have no idea what to do on android or if it's even necessary. I know that's not helpful but that's what I've got at this moment. If you want to put this on ice in case I get around to checking out Android I would say that's fine.

@lukepighetti
Copy link
Author

Looks like I won't be getting around to nailing this down on Android. I won't be upset if you close this out. Thank you for your time.

@Larpoux
Copy link
Collaborator

Larpoux commented Mar 28, 2020

No, do not close this issue until we look to that seriously.
But time is really a problem. I have too many things in the pipeline...

@Larpoux
Copy link
Collaborator

Larpoux commented Apr 5, 2020

Hi @lukepighetti ,

I am looking to your Pull Request.
I am wondering if instead for adding a new API verb, it would be good to always do a isMeteringEnabled: true when the App call the API verb setDbLevelEnabled(true)

I guess that if the App wants to control the amplitude meter, this one must be accurate, even if it means some CPU eating.

@Larpoux
Copy link
Collaborator

Larpoux commented Apr 8, 2020

We added the iOS call to setMeteringEnabled:YES in setDbLevelEnabled(true).

@Larpoux Larpoux closed this Apr 8, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants