Skip to content
This repository has been archived by the owner on May 7, 2023. It is now read-only.

Fix Image Styles #200

Merged
merged 1 commit into from Aug 15, 2020
Merged

Conversation

0916dhkim
Copy link
Member

Specify project

Client-side

Description

Width and height props of Image components were used incorrectly.
As a result, some icons are not visible inside web client.

Specify width and height as style props instead of component props.

Current State

current

Fixed State

fixed

Checklist

Before you create this PR confirms that it meets all requirements listed below by checking the relevant checkboxes ([x]). This will ensure a smooth and quick review process.

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I signed the [CLA].
  • Run yarn lint && yarn tsc
  • Run yarn test or yarn test -u if you need to update snapshot.
  • I am willing to follow-up on review comments in a timely manner.

Width and height props of Image components were used incorrectly.
Specify width and height as style props instead of component props.
@codecov
Copy link

codecov bot commented Aug 15, 2020

Codecov Report

Merging #200 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #200   +/-   ##
=======================================
  Coverage   66.08%   66.08%           
=======================================
  Files          35       35           
  Lines         634      634           
  Branches       56       56           
=======================================
  Hits          419      419           
  Misses        202      202           
  Partials       13       13           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5d3b4e6...abd4ef1. Read the comment docs.

Copy link
Member

@hyochan hyochan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah! This fix is great!
So we should always use styles to support web.

@hyochan hyochan merged commit 6846499 into dooboolab-community:master Aug 15, 2020
@hyochan
Copy link
Member

hyochan commented Aug 15, 2020

@all-contributors Please add @0916dhkim for code.

@allcontributors
Copy link
Contributor

@hyochan

I've put up a pull request to add @0916dhkim! 🎉

@hyochan hyochan added this to the Contributon 2020 milestone Aug 17, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants