Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Makes path param in startRecord to behave as a path on iOS #94

Merged
merged 1 commit into from
Jul 30, 2019

Conversation

escobar5
Copy link
Contributor

The path parameter of the method startRecord behaves as a path on Android, where you can pass for example 'sdcard/hello.mp4'. On iOS it was only supporting the fileName, this fix makes the function consistent between iOS and Android, both now can take a path.

Fixes #90

The path parameter of the method startRecord behaves as a path on Android, where you can pass for example 'sdcard/hello.mp4'. On iOS it was only supporting the fileName, this fix makes the function consistent between iOS and Android, both now can take a path.

Fixes hyochan#90
Copy link
Owner

@hyochan hyochan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approve this PR.

@hyochan hyochan merged commit 276e874 into hyochan:master Jul 30, 2019
@mdathersajjad
Copy link

mdathersajjad commented Aug 28, 2019

Can you please update the README regarding the same in tips section it has been mentioned if we give file name sound.m4a we will get back the file URI previously it used to return temporary path plus the file name now we have to pass the whole path and to get the file path we have to include library like react-native-fs or write a custom native module to get the temporary file path. As a suggestion you can add a constants in both android and ios to get the temporary path it will be really helpful. If you want i can open a pull request for the same. Also the path /sdcard/sound.mp4 would be available or not depends on the phone manufacturer. Different vendors put the path in different places.

Thanks

@hyochan
Copy link
Owner

hyochan commented Aug 28, 2019

Please give us a PR to help us maintain the module!

@hyochan hyochan mentioned this pull request Sep 30, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Parameter path should be a path and not a file name on iOS
3 participants