Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix changing subscriptions on Android #1129

Merged
merged 3 commits into from Sep 25, 2020
Merged

Fix changing subscriptions on Android #1129

merged 3 commits into from Sep 25, 2020

Conversation

M46N3
Copy link
Member

@M46N3 M46N3 commented Sep 25, 2020 •
edited

Added the new way to upgrade/downgrade from a previous subscription when subscribing to a new one on Android. Calls setOldSku as described in Android docs

This PR fixes #1128

@hyochan hyochan added 🚽 migration Activities due to changes in framework ⌚️ regression Things that worked previously labels Sep 25, 2020
hyochan
hyochan approved these changes Sep 25, 2020
View reviewed changes
Copy link
Member

@hyochan hyochan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like an awesome fix. However, don't you think we can rename purchaseToken to purchaseTokenAndroid if this isn't needed in iOS in the next updates?

@hyochan hyochan merged commit d5785e5 into dooboolab-community:master Sep 25, 2020
@M46N3
Copy link
Member Author

M46N3 commented Sep 25, 2020

Yes, indeed that would probably be a better name, both for future updates and stating more clearly what it does.

@M46N3 M46N3 mentioned this pull request Sep 25, 2020
Merged
hyochan pushed a commit that referenced this pull request Sep 26, 2020
@M46N3
Renamed purchaseToken -> purchaseTokenAndroid (#1130)
a0012aa 
Renamed purchaseToken to purchaseTokenAndroid, as discussed in PR #1129
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hyochan hyochan hyochan approved these changes

Assignees
No one assigned
Labels
🚽 migration Activities due to changes in framework ⌚️ regression Things that worked previously
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Changing subscriptions on Android broken
2 participants
@M46N3 @hyochan