Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add introductory price as string without formating and currency #1182

Merged
merged 1 commit into from
Nov 21, 2020
Merged

Add introductory price as string without formating and currency #1182

merged 1 commit into from
Nov 21, 2020

Conversation

manishaggarwalm
Copy link
Contributor

Add introductory price as string without formating and currency

@manishaggarwalm manishaggarwalm force-pushed the feature/introductory-price-as-amount branch 4 times, most recently from 58dc5de to 60eac70 Compare November 10, 2020 08:22
@hyochan hyochan added the 🍗 enhancement New feature or request label Nov 12, 2020
hyochan
hyochan requested changes Nov 12, 2020
View reviewed changes
Copy link
Member

@hyochan hyochan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your contribution. If introductoryPriceAsAmount is only returned by iOS what about changing this var to introductoryPriceAsAmountIOS?

@manishaggarwalm manishaggarwalm force-pushed the feature/introductory-price-as-amount branch from 60eac70 to a0474f2 Compare November 13, 2020 09:44
@manishaggarwalm manishaggarwalm force-pushed the feature/introductory-price-as-amount branch from a0474f2 to 3f6610f Compare November 13, 2020 09:45
@manishaggarwalm
Copy link
Contributor Author

Thanks for your contribution. If introductoryPriceAsAmount is only returned by iOS what about changing this var to introductoryPriceAsAmountIOS?

Fixed the naming form introductoryPriceAsAmount to introductoryPriceAsAmountIOS.

hyochan
hyochan approved these changes Nov 21, 2020
View reviewed changes
Copy link
Member

@hyochan hyochan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the changes!! 💯

@hyochan hyochan merged commit 73ea9ba into dooboolab-community:master Nov 21, 2020
hyochan added a commit that referenced this pull request Nov 21, 2020
@hyochan
Release 5.1.2
ab25d81 
Lint fixes & applied #1186 #1182
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hyochan hyochan hyochan approved these changes

Assignees
No one assigned
Labels
🍗 enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@manishaggarwalm @hyochan @accolite-maggarwall