improve receipt types #1461
Merged
improve receipt types #1461
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
andresesfm
commented
Aug 10, 2021
andresesfm
commented
- Added isCanceled to amazon properties
- fix lint
- cleaned up types and refactored common code across platforms
- refactor receipt conversion for Amazon
- verbiage
hyochan
reviewed
Aug 10, 2021
| @@ -13,7 +13,7 @@ | |||
| "apsl-react-native-button": "3.1.1", | |||
| "react": "17.0.1", | |||
| "react-native": "0.64.2", | |||
| "react-native-iap": "file:..", | |||
There was a problem hiding this comment.
Is there any reason why reverting this?
There was a problem hiding this comment.
Yes, I've been testing and it turns out that Metro doesn't pick up on this notation. Reference here: facebook/metro#68 I really wanted it to work, I ended up using wml: https://github.com/wix/wml#readme which is not great but it gets the job done. I really hope they enable linking on Metro at some point. In the meantime, there's no point in pointing to a file
There was a problem hiding this comment.
Thanks for spotting the issue. Have you also tried this?
Anyway, let's merge this PR and we may of this afterward.
hyochan
force-pushed
the
improve_receipt_types
branch
from
4de8c44
to
a5b315b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.