Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add buyWithQuantity iOS function #240

Merged
merged 5 commits into from Aug 16, 2018

Conversation

lefoy
Copy link
Contributor

@lefoy lefoy commented Aug 16, 2018

This PR add the buyWithQuantity iOS only function. I also added an optional parameter to the buyProductWithoutFinishTransaction since it's already iOS only.

index.js Outdated Show resolved Hide resolved
@hyochan
Copy link
Member

hyochan commented Aug 16, 2018

@lefoy Could you review above and give some changes in naming?

index.js Outdated Show resolved Hide resolved
@lefoy
Copy link
Contributor Author

lefoy commented Aug 16, 2018

@dooboolab The PR should be ready to merge now, let me know if I missed something

@hyochan
Copy link
Member

hyochan commented Aug 16, 2018

@lefoy Looks good. I'll merge this and publish to 2.0.0-alpha8. Thank you for your great work!

@hyochan hyochan merged commit 5d52073 into dooboolab-community:master Aug 16, 2018
@lefoy
Copy link
Contributor Author

lefoy commented Aug 16, 2018

Thank you! 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🎯 feature New feature 📱 iOS Related to iOS
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants