Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix issue with promoted product event not firing on older devices #390

Conversation

neilco
Copy link
Contributor

@neilco neilco commented Jan 31, 2019

This pull request fixes #389 by listening for -[paymentQueue:addAddStorePayment:forProduct:] far earlier in the native app lifecycle than would otherwise be possible in pure React Native.

@hyochan hyochan added 📱 iOS Related to iOS 🛠 bugfix All kinds of bug fixes labels Feb 1, 2019
@hyochan hyochan self-requested a review February 1, 2019 18:59
@hyochan
Copy link
Member

hyochan commented Feb 1, 2019

I've just tested if example project is properly working and build successfully (no one to help out to review this feature yet. I hope you could review changes if anyone else contribute on this). Thank you for contribution.

@hyochan hyochan merged commit 93b2d48 into dooboolab-community:master Feb 1, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🛠 bugfix All kinds of bug fixes 📱 iOS Related to iOS
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Promoted product event not raised on older devices
2 participants