Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update Gradle 3.2.1 - build tools version 28.0.3 #488

Merged
merged 1 commit into from
May 16, 2019
Merged

Update Gradle 3.2.1 - build tools version 28.0.3 #488

merged 1 commit into from
May 16, 2019

Conversation

skantus
Copy link
Contributor

@skantus skantus commented May 14, 2019

This PR updates Gradle version to 3.2.1 and default build tools version to 28.0.3 to avoid warnings in most versions.

Captura de pantalla 2019-05-14 a las 15 40 21

⚠️ Needed to be tested.

@skantus
Update Gradle 3.2.1 - build tools version 28.0.3
8e74762 
This PR updates _Gradle_ version to `3.2.1` and default build tools version to `28.0.3` to avoid warnings in most versions.

![Captura de pantalla 2019-05-14 a las 15 40 21](https://user-images.githubusercontent.com/4986411/57704395-186a4100-7662-11e9-8e56-408358bed6b6.png)

⚠️ Needed to be tested.
@hyochan hyochan added 🤖 android Related to android 👷‍♀️ build Build issue labels May 15, 2019
@hyochan
Copy link
Member

hyochan commented May 15, 2019

This PR won't be merged unless someone confirms this after testing.

hyochan
hyochan requested changes May 15, 2019
View reviewed changes
Copy link
Member

@hyochan hyochan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Need to be approved after testing.

@skantus
Copy link
Contributor Author

skantus commented May 15, 2019 •
edited

Need to be approved after testing.

@hyochan I did not have time for the test, but I'll see that it worked perfectly.

I will confirm it soon.

hyochan
hyochan approved these changes May 16, 2019
View reviewed changes
Copy link
Member

@hyochan hyochan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approve this PR. I've just finished testing it.

@hyochan hyochan merged commit 4131299 into dooboolab-community:master May 16, 2019
@skantus skantus deleted the patch-1 branch June 10, 2019 13:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hyochan hyochan hyochan approved these changes

Assignees
No one assigned
Labels
🤖 android Related to android 👷‍♀️ build Build issue
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@skantus @hyochan