Warning: repos that have renamed "master" branch to "main" must be fixed manually on doom update or doom upgrade

[telotortium]

doom upgrade (and I presume doom update) aborts if upstream has changed the default branch name (for example, from master to main). Example failure:

$ doom -d upgrade -p
...
> (280/288) Fetching websocket...nil
x There was an unexpected error:
  Type: doom-package-error
  Message:
    Error with packages
  Data:
    "websocket"
    (error "Failed to run \"git\"; see buffer *straight-process*")
  Straight output:
    fatal: couldn't find remote ref refs/heads/master

This is because https://github.com/ahyatt/emacs-websocket has renamed their "master" branch to "main". Git doesn't handle this situation automatically if you've already cloned a local copy. It can be fixed with instructions from the aforementioned article:

$ git checkout master
$ git branch -m master main
$ git fetch
$ git branch --unset-upstream
$ git branch -u origin/main
$ git symbolic-ref refs/remotes/origin/HEAD refs/remotes/origin/main

[hlissner]

This should probably be reported upstream to straight. It defaults to cloning master in the absence of an explicit branch. Though, I suspect no good, general solution for this exists.

Neither Doom nor straight is able to guess what a (remote) repo's main branch is, or whether the current branch was necessarily renamed to main or some other arbitrary name.

Perhaps melpa should update it's recipes to include branch names.

[jcf]

@hlissner I've taken the liberty of opening a couple of issues. One over in the emacs-websocket repo where I think it'd be considerate to let people know about the breaking change, and one over in the straight.el repo.

[raxod502]

A permanent solution to this problem has been discussed already. Some nontrivial work is required, but I do not think the problem is insurmountable in principle.

[randomizedthinking]

@telotortium can you show step-by-step instructions what we need to do?

[telotortium]

@randomizedthinking My instructions above don't work?

[randomizedthinking]

@telotortium To me, websocket is a package in the middle. After running your commands inside .emacs.d/.local/straight/repos/emacs-websocket, I still stuck with doom update: I would like to update the rest of the packages after websocket, but it won't work.

Update: I didn't do anything and doom update now works. Thank all upstream maintainers for making it happen.

[panchoh]

Workaround (CAVEAT EMPTOR: with full rebuild)

Assumptions:

• You already have a working set of config files (e.g.: ~/.config/doom/*)

Workaround proper

EMACSDIR="~/.emacs.d" # Ensure this is accurate!
mv -iv "$EMACSDIR" "$EMACSDIR".bck
git clone --depth 1 https://github.com/hlissner/doom-emacs.git "$EMACSDIR"
"$EMACSDIR"/bin/doom sync

doom sync will emit a warning:

    → Building ein → Cloning emacs-websocket...

Warning (straight): Could not check out branch "master" of repository "emacs-websocket"
    → Building ein → Cloning emacs-websocket...done

... but will compile it anyway:

$ ls -l ~/.emacs.d/.local/straight/build/websocket/
total 68
lrwxrwxrwx 1 pancho pancho    72 Jun 23 07:04 websocket.el -> /home/pancho/.emacs.d/.local/straight/repos/emacs-websocket/websocket.el
-rw-r--r-- 1 pancho pancho 62441 Jun 23 07:04 websocket.elc

Hope that it helps!

[raxod502]

Perhaps I am missing something, but why can you not just go into the websocket repository and manually git checkout main? The whole point of straight.el is that you can always do stuff manually if the package manager is not smart enough.

[panchoh]

Perhaps I am missing something, but why can you not just go into the websocket repository and manually git checkout main? The whole point of straight.el is that you can always do stuff manually if the package manager is not smart enough.

That's the first thing I tried. But in my case, the repo was already tracking main. The problem happens after that, when running doom upgrade. It complains about an issue with master, and won't cooperate. Doing the doom sync route works nicely, though.

[imsodin]

I got these kind of errors also when cleaning out repos to start from scratch due to init.defaultBranch. I fixed that issue upstream: radian-software/straight.el#739
I'd appreciate if the pin could be bumped to that :)

[github-actions]

This issue has been automatically marked stale because of a lack of recent activity. If this issue is still valid, reply to it or remove the label or it will be closed in 7 days.

[yeldiRium]

Stalebot strikes once again and closes a relevant and unresolved issue.