Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Large title bar on macOS Sonoma when using railwaycat/homebrew-emacsmacport and Doom Emacs #7532

Closed
4 tasks done
adamliter opened this issue Oct 31, 2023 · 2 comments
Closed
4 tasks done
Labels
invalid Unactionable, unrelated, inappropriate, or a pilot error

Comments

@adamliter
Copy link

I confirm that...

  • I have searched the issue tracker, documentation, FAQ, Discourse, and Google, in case this issue has already been reported/resolved.

  • I have read "How to Debug Issues", and will use it to provide as much information about this issue as possible.

  • The issue can be reproduced on the latest available commit of Doom.

  • The issue can be reproduced on a stable release of Emacs, such as 27, 28, or 29. (Unstable versions end in .50, .60, or .9x)

Expected behavior

The expected behavior is to have a normal-sized title bar when opening Doom Emacs on macOS Sonoma. After upgrading to macOS Sonoma, something has changed, and it seems like a bug in Doom Emacs, based on the discussion here.

This is also discussed in railwaycat/homebrew-emacsmacport#362.

Current behavior

Opening Doom Emacs on macOS Sonoma leads to a title bar of this size:

image

However, running /Applications/Emacs.app/Contents/MacOS/Emacs -q --eval '(tool-bar-mode 0)' & leads to a title bar of this size:

image

Steps to reproduce

  1. brew install emacs-mac --with-natural-title-bar
  2. /Applications/Emacs.app/Contents/MacOS/Emacs -q to get large title bar
  3. /Applications/Emacs.app/Contents/MacOS/Emacs -q --eval '(tool-bar-mode 0)' to get small/reasonable title bar
  4. /Applications/Emacs.app/Contents/MacOS/Emacs to get large title bar with Doom configuration (regardless of whether config.el contains (tool-bar-mode 0))

Adding (add-hook 'doom-after-init-hook (lambda () (tool-bar-mode 1) (tool-bar-mode 0))) to config.el is a workaround as suggested by Dolerich in the linked Discourse post.

System Information

https://pastebin.com/embed_js/ZGGDx9NA

@adamliter adamliter added is:bug Something isn't working as intended needs-triage Issue hasn't been assessed yet labels Oct 31, 2023
@adamliter
Copy link
Author

I think this was likely an upstream issue in emacs-mac. mituharu/emacs-mac@5f6c306 purports to have fixed it. I haven't had a chance to try out the fix myself yet, but I'll tentatively close this issue. Thanks and sorry for the noise!

@hlissner hlissner added invalid Unactionable, unrelated, inappropriate, or a pilot error and removed is:bug Something isn't working as intended needs-triage Issue hasn't been assessed yet labels Nov 29, 2023
@DivineDominion
Copy link

In case someone else googles this:

The underlying issue is that the toolbar needs to be disabled before the window title bar style is changed. If you don't have the patched Emacs binary, you can toggle M-x tool-bar-mode on and off again interactively. That will be long after the startup sequence has set the window title and shrink the title bar.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
invalid Unactionable, unrelated, inappropriate, or a pilot error
Projects
None yet
Development

No branches or pull requests

3 participants