Default enforceSingleInvocation=true #14
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Since the introduction of [RN autolink](https://reactnative.dev/docs/linking-libraries-ios#automatic-linking), we don't have the opportunity to instantiate the module ourselves anymore, so it's not possible to pass a custom constructor parameter. Diving into the code, I realized this value is just hardcoded in the source, so I changed it according to the readme, that claims it must be initialized with true to avoid redundant values.
|
Hi! This feature was added as a PR earlier, and I asked author to add it as flag to keep default behavior. Probably |
|
@doomsower Do you mean this PR could be approved if the README just reflected the new behavior? I can take care of that. |
|
@doomsower just a reminder, I made the changes to the README, if there's something else that needs changed just tell me |
doomsower
pushed a commit
that referenced
this pull request
Apr 25, 2021
# [2.0.0](v1.3.0...v2.0.0) (2021-04-25) ### Features * Merge pull request [#14](#14) from lucasfeijo/patch-1 ([42a718e](42a718e)) ### BREAKING CHANGES * on Android, `enforceSingleInvocation` is true by default
|
🎉 This PR is included in version 2.0.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since the introduction of RN autolink, we don't have the opportunity to instantiate the module ourselves anymore, so it's not possible to pass a custom constructor parameter. Diving into the code, I realized this value is just hardcoded in the source, so I changed it according to the readme, that claims it must be initialized with true to avoid redundant values.