NoMethodError at /oauth/authorize/native with doorkeeper 5.0

[nhosoya]

I noticed that native_oauth_authorization_path( /oauth/authorize/native ) returns the error :

undefined method `application' for nil:NilClass

at here.
This occurs only with doorkeeper 5.0.

--
Probably caused by this changes.
doorkeeper-gem/doorkeeper@698fba0

[toupeira]

Thanks for the report!

What version of doorkeeper-openid_connect are you on? Does this still happen with 1.5.2?

Also, can you describe how to reproduce the error?

[nhosoya]

This error is reproduced with

ruby 2.5.1
rails 5.2.1
doorkeeper 5.0.0
doorkeeper-openid_connect 1.5.2

I created minimum repository to reproduce this.
https://github.com/nhosoya/doorkeeper-openid_connect-sample

Steps to reproduce:

1. Create new oauth application that redirect_uri is urn:ietf:wg:oauth:2.0:oob.
2. Access to Authorization Endpoint for this application and authorize.
   (Or access directly /oauth/authorize/native?code=aaa)

Only doorkeeper(without doorkeeper-openid_connect), this error is not reproduced.
https://github.com/nhosoya/doorkeeper-openid_connect-sample/tree/only-doorkeeper

[arianvp]

I'm running into exactly the same issue.

[a-tommyyy]

doorkeeper-openid_connect/lib/doorkeeper/openid_connect/helpers/controller.rb

Line 10 in 6829c58

next unless pre_auth.scopes.include? 'openid'

i think this line should be changed like below

next unless pre_auth&.scopes&.include? 'openid' 

[toupeira]

Apologies for the long delay, and happy new year everyone! 😁

I'm not really sure how the native authorization works, but #60 should fix the exception.

Please try again with the new version 1.5.3.

[nhosoya]

It works fine. Thank you, and happy new year! 😃

[toupeira]

@nhosoya great, thanks for checking! 👍