Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Resource owner is called on invalid client_credentials #1506

Closed
jarosan opened this issue Apr 22, 2021 · 2 comments
Closed

Resource owner is called on invalid client_credentials #1506

jarosan opened this issue Apr 22, 2021 · 2 comments
Labels

Comments

@jarosan
Copy link

jarosan commented Apr 22, 2021

I have an app that uses Password Credentials flow and load the user with resource_owner_from_credentials.

When the request to get the token comes with an invalid client_id and/or client_secret i would expect resource_owner_from_credentials never to get called as the request would fail anyway with a 401. However the method is still called.

Problem is that my resource_owner_from_credentials is fetching user data from external service and i would want to avoid doing unnecessary external calls for requests that will fail with a 401 due to invalid client.

@nbulaj
Copy link
Member

nbulaj commented Apr 27, 2021

Hi @jarosan. I have to check why it not fast fail for the case when credentials are invalid, but anyway PRs are welcome!
Thanks for pointing this out

@stale
Copy link

stale bot commented Jun 26, 2021

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the wontfix label Jun 26, 2021
@stale stale bot closed this as completed Jul 7, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants