Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Auth via header should use token #46

Closed
cj opened this issue Feb 7, 2012 · 1 comment
Closed

Auth via header should use token #46

cj opened this issue Feb 7, 2012 · 1 comment

Comments

@cj
Copy link

cj commented Feb 7, 2012

I think the authentication via header should be like github's curl -H "Authorization: token OAUTH-TOKEN" https://api.github.com rather than what doorkeepers currently is curl -H "Authorization: OAUTH-TOKEN" https://api.github.com. Changing it will allow basic/digest auth etc....

source: http://developer.github.com/v3/

@felipeelias
Copy link
Member

Github probably uses an extension of access token.

We already accept header authorization via Bearer token, which is defined in section 7.1. This is also compatible with the oauth2 gem (if you use the defaults).

Not sure if it makes sense to change this right now. However, access token extensibility is definitely one of the features we should add in the future.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants