Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FieldCollector and DSLBuilder.isUsing(FieldId) #28

Merged
merged 4 commits into from May 28, 2019
Merged

Conversation

gdigugli
Copy link
Member

new API available for ValidationRule and MappingRule allows to test if a particular FieldId is used in the implementation of a mapping or validation rule. It enables filtering on a set of rules.

@codecov
Copy link

codecov bot commented May 23, 2019

Codecov Report

Merging #28 into master will increase coverage by 2.3%.
The diff coverage is 85.41%.

Impacted file tree graph

@@             Coverage Diff             @@
##             master      #28     +/-   ##
===========================================
+ Coverage     51.84%   54.14%   +2.3%     
- Complexity      117      142     +25     
===========================================
  Files           232      235      +3     
  Lines          5937     5978     +41     
  Branches        363      364      +1     
===========================================
+ Hits           3078     3237    +159     
+ Misses         2753     2632    -121     
- Partials        106      109      +3
Impacted Files Coverage Δ Complexity Δ
.../java/io/doov/assertions/ValidationRuleAssert.java 81.81% <100%> (+10.38%) 5 <2> (+2) ⬆️
...in/java/io/doov/core/dsl/meta/ast/FoldVisitor.java 100% <100%> (ø) 0 <0> (?)
...s/src/main/java/io/doov/assertions/Assertions.java 80% <100%> (+5%) 4 <1> (+1) ⬆️
...rc/main/java/io/doov/core/dsl/lang/DSLBuilder.java 80% <100%> (+5%) 0 <0> (ø) ⬇️
...ava/io/doov/core/dsl/meta/ast/AstHtmlRenderer.java 94.92% <100%> (ø) 0 <0> (ø) ⬇️
...ava/io/doov/core/dsl/meta/ast/AstVisitorUtils.java 94.11% <100%> (ø) 0 <0> (ø) ⬇️
...ain/java/io/doov/assertions/MappingRuleAssert.java 60% <60%> (ø) 2 <2> (?)
...java/io/doov/core/dsl/meta/ast/FieldCollector.java 78.57% <78.57%> (ø) 0 <0> (?)
.../java/io/doov/sample/benchmark/BenchmarkSetup.java 77.77% <0%> (-7.41%) 6% <0%> (-2%)
.../io/doov/sample/benchmark/bv/SimpleValidation.java 83.33% <0%> (-5.56%) 2% <0%> (ø)
... and 11 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 75df31b...e3d6ecc. Read the comment docs.

@ozangunalp ozangunalp merged commit 020d77d into master May 28, 2019
@ozangunalp ozangunalp deleted the is_using_field branch May 28, 2019 08:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants