Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add component types filter on ISerializer #32

Closed
Doraku opened this issue Mar 14, 2019 · 3 comments
Closed

add component types filter on ISerializer #32

Doraku opened this issue Mar 14, 2019 · 3 comments
Labels
enhancement New feature or request
Milestone

Comments

@Doraku
Copy link
Owner

Doraku commented Mar 14, 2019

There is probably some component type which you do not want serialization (texture, ...), their should be a way to ignore them.

@Doraku Doraku added the enhancement New feature or request label Mar 14, 2019
@Doraku Doraku added this to the 1.0 milestone Mar 14, 2019
@prime31
Copy link

prime31 commented Mar 23, 2019

I’m in the process of building a serializer now. This is just my opinion, but I don’t think DefaultECS needs a serializer in the library. Serialization is so game specific that it would be nearly impossible to make one that would be useful.

@Doraku
Copy link
Owner Author

Doraku commented Mar 23, 2019

I've been wondering for a while to leave both my serializers in or move them to their own package, only leaving IComponentReader and IComponentTypeReader in the framework to at least keep an open door for people wanting to make their own serializer... Since they doesn't bring extra dependencies there is no harm for now, maybe one day I won't be too lazy to actually do it.

@prime31
Copy link

prime31 commented Mar 23, 2019

Haha. I know the feeling about being lazy ;)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants