Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Number of completed tests mismatches passed/failed #319

Closed
dominicmh opened this issue Nov 20, 2023 · 1 comment · Fixed by #426
Closed

Number of completed tests mismatches passed/failed #319

dominicmh opened this issue Nov 20, 2023 · 1 comment · Fixed by #426
Assignees
Labels
bug Something isn't working dart Pull requests that update Dart code
Milestone

Comments

@dominicmh
Copy link
Contributor

dominicmh commented Nov 20, 2023

The numbers presented in the test result don't seem to add up:

13 tests were completed in 274s with 12 passed, 0 failed and 0 skipped.

I don't understand how the number of completed tests is formed. But I would assume it to be the sum of passed + failed.
In fact, in the given test suite, there were 12 tests (test(…);) included. So I would have expected "12 tests were completed …".

This is the originating test results file of reporter: "flutter-json":
test-results.json

@dominicmh
Copy link
Contributor Author

dominicmh commented Apr 11, 2024

According to the documentation of the TestDoneEvent, the hidden "tests" should be ignored:

The hidden attribute indicates that the test's result should be hidden and not
counted towards the total number of tests run for the suite. This is true for
virtual tests created for loading test suites, setUpAll(), and
tearDownAll(). Only successful tests will be hidden.

This could be easily fixed by removing "tests" with the hidden flag on the TestDoneEvent from the test result.

@jozefizso, would this solution be accepted as a PR? Let me know if you need more background information!

@jozefizso jozefizso added bug Something isn't working dart Pull requests that update Dart code labels May 8, 2024
@jozefizso jozefizso added this to the v1.9.1 milestone May 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working dart Pull requests that update Dart code
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants