Fix a couple CWE issues in ManyMouse #2040
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kcgen
added
cleanup
FeralChild64
requested changes
Oct 22, 2022
In pump_events, the event struct members are used initialized in three places: 1. Line 479, the event struct is passed into queue_event() which accesses the event's minval member, but it hasn't been written to at this point. 2. Line 488, the event struct is passed into queue_event() which accesses the event's minval member, but it hasn't been written to at this point. 3. Line 505, the event struct is passed into queue_event() which accesses the event's item member, but it hasn't been written to at this point.
kcgen
force-pushed
the
kc/manymouse-cwes-1
branch
from
cb1e1cf
to
227aa54
Compare
kcgen
commented
Oct 23, 2022
FeralChild64
approved these changes
Oct 23, 2022
Fixes: warning: implicit conversion changes signedness: 'unsigned int' to 'int'
TOCTOU security issues exists between a check event and a use event in which an attacker can change properties about the thing being used. In this case, the code checked several stat-based properties about the mouse's character-device file path, and once verified, opened the the file path as a bona fide mouse device. Because the same open file descriptor isn't maintained across the checks through to the usage, we can't be guaranteed that file used is the one we checked (the crux of the TOCTOU vulnerability). To fix it, we hold the sample file descriptor across the checks and usage.
kcgen
force-pushed
the
kc/manymouse-cwes-1
branch
from
227aa54
to
077230a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Suggest reviewing commit by commit.