FAT image mounting fixes #2278
Merged
FAT image mounting fixes #2278
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
NicknineTheEagle
commented
Feb 12, 2023
•
NicknineTheEagle
commented
- Change FAT images to use modify time instead of creation time as file time returned by DOS function 57h and used by COPY command. Using creation time here makes no sense since creation time in FAT wasn't even implemented until MS-DOS 7.0 (Windows 95 DOS mode) and most old floppies don't have it set.
- Implement setting file time in mounted FAT images. Right now, editing files does not update file time and new files have time set to epoch.
- Proper r/o file attribute handling in FAT images as well as better feedback when the image is mounted in r/o mode.
NicknineTheEagle
force-pushed
the
nn/drive-fat
branch
2 times, most recently
from
7f3aaad
to
09a2e86
Compare
NicknineTheEagle
changed the title
NicknineTheEagle
force-pushed
the
nn/drive-fat
branch
from
704d292
to
925bda0
Compare
NicknineTheEagle
changed the title
johnnovak
reviewed
Feb 13, 2023
johnnovak
reviewed
Feb 13, 2023
kcgen
reviewed
Feb 13, 2023
kcgen
reviewed
Feb 13, 2023
kcgen
reviewed
Feb 13, 2023
kcgen
reviewed
Feb 13, 2023
kcgen
reviewed
Feb 13, 2023
kcgen
reviewed
Feb 13, 2023
kcgen
reviewed
Feb 13, 2023
kcgen
reviewed
Feb 13, 2023
kcgen
reviewed
Feb 13, 2023
kcgen
reviewed
Feb 13, 2023
NicknineTheEagle
force-pushed
the
nn/drive-fat
branch
3 times, most recently
from
b72c804
to
1cdb766
Compare
kcgen
reviewed
Feb 13, 2023
kcgen
reviewed
Feb 13, 2023
kcgen
reviewed
Feb 13, 2023
kcgen
requested changes
Feb 13, 2023
There was a problem hiding this comment.
Looking good @NicknineTheEagle! Just three comments left fro me.
kcgen
reviewed
Feb 13, 2023
NicknineTheEagle
force-pushed
the
nn/drive-fat
branch
from
1cdb766
to
0b9c371
Compare
NicknineTheEagle
force-pushed
the
nn/drive-fat
branch
from
0b9c371
to
2dc031a
Compare
kcgen
approved these changes
Feb 13, 2023
There was a problem hiding this comment.
Can't see anything else; thanks @NicknineTheEagle.
Also covers @johnnovak's feedback, so I think we're set.
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.