Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Increase max memory size to 3072 MB, minor cleanup #2334

Merged
merged 1 commit into from Mar 13, 2023
Merged

Increase max memory size to 3072 MB, minor cleanup #2334

merged 1 commit into from Mar 13, 2023

Conversation

FeralChild64
Copy link
Collaborator

  • further increased maximum memory size - to the point where emulated S3 linear framebuffer starts
  • cleaned up the memory code a little
  • additional warning is printed if selected memory size is above what Windows 95 supports
  • tested that PATCHMEM by Rudolph R. Loew allows to use full 3072 MB RAM, at least with Windows 95

@FeralChild64 FeralChild64 added enhancement New feature or enhancement of existing features cleanup Non-functional changes that simplify, improve maintainability, or squash warnings labels Mar 12, 2023
@FeralChild64 FeralChild64 self-assigned this Mar 12, 2023
@ThomasEricB
Copy link
Contributor

This is very nice!!!! Great work as always @FeralChild64 !

kcgen
kcgen reviewed Mar 13, 2023
View reviewed changes
src/dosbox.cpp Show resolved Hide resolved
@kcgen kcgen self-requested a review March 13, 2023 02:39
@kcgen
Copy link
Member

kcgen commented Mar 13, 2023 •
edited

Looks good @FeralChild64 ; glad you could test these limits, too.

Will hold off on merging till @johnnovak has a scan through.

johnnovak
johnnovak approved these changes Mar 13, 2023
View reviewed changes
Copy link
Member

@johnnovak johnnovak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good @FeralChild64

@kcgen kcgen merged commit 19adc70 into main Mar 13, 2023
58 checks passed
@FeralChild64 FeralChild64 deleted the fc/huge-ram-1 branch March 14, 2023 18:00
@Grounded0 Grounded0 mentioned this pull request Nov 17, 2023
Closed
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@johnnovak johnnovak johnnovak approved these changes

@kcgen kcgen kcgen approved these changes

Assignees

@FeralChild64 FeralChild64

Labels
cleanup Non-functional changes that simplify, improve maintainability, or squash warnings enhancement New feature or enhancement of existing features
Projects
0.81 Project
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@FeralChild64 @ThomasEricB @kcgen @johnnovak