Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Group together shell error strings #2343

Merged
merged 2 commits into from Mar 16, 2023
Merged

Group together shell error strings #2343

merged 2 commits into from Mar 16, 2023

Conversation

FeralChild64
Copy link
Collaborator

String-related cleanup:

  • grouped all the 'generic' shell strings - this way they will be easier to find when developing command/program
  • made their IDs uniform
  • dropped one string from MOUSECTL, add newline at the end of its error messages
  • fixed one mistake in Polish translation

No action from translators should be necessary.

@FeralChild64 FeralChild64 added cleanup Non-functional changes that simplify, improve maintainability, or squash warnings translation Issues related to translations labels Mar 15, 2023
@FeralChild64 FeralChild64 self-assigned this Mar 15, 2023
Copy link
Member

@kcgen kcgen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Excellent systematic cleanup, @FeralChild64 !

All looks good from my side.

src/shell/shell.cpp Outdated Show resolved Hide resolved
Copy link
Member

@johnnovak johnnovak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice cleanup job @FeralChild64 👍🏻

src/shell/shell.cpp Outdated Show resolved Hide resolved
@kcgen
Copy link
Member

kcgen commented Mar 16, 2023

Another big clean up -- nice, @FeralChild64 !

@MeAreJeenius , this touches some of Shell and its translation messages (but not Shell Batch); fingers crossed your branch rebases clean once this lands in main.

@kcgen kcgen merged commit 5834943 into main Mar 16, 2023
58 checks passed
@FeralChild64 FeralChild64 deleted the fc/string-cleanup-1 branch March 16, 2023 20:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cleanup Non-functional changes that simplify, improve maintainability, or squash warnings translation Issues related to translations
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

None yet

3 participants