Make the DOS module depend on SDL2 net #2358
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The DOS serial port CLI tool includes misc_utils.h, which depends on SDL2 net structures.
kcgen
added
SDL
|
Passing CI, and now confirmed working on NixOS as well:
Thanks @ThomasEricB ! |
Wrong photo! Doesn't look as clean because of the unrelated voodoo branch errors LOL
Anytime :) |
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The DOS serial port CLI tool includes
misc_utils.h, which depends on SDL2 net
structures.
Thanks to @ThomasEricB for flagging this, and for NixOS's separate per-package include directories revealing this (the DOS module already depends on SDL but not on SDL2_net; we just 'got lucky' on existing platforms because the SDL2 net headers are often placed inside the same directory as the SDL2 headers).