New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement TREE.COM command #2366

Merged

kcgen merged 3 commits into main from fc/tree-1

Mar 28, 2023

Collaborator

FeralChild64 commented Mar 26, 2023

Implemented command TREE, with various extensions from DR-DOS / FreeDOS
Reworked commands LS and DIR, so that they now share parts of code with TREE. As a result:

DIR now uses our MORE text engine, giving nicer display with /p option
DIR command options /os and /o-s now work correctly - they handle directories as objects of size 0, like in MS-DOS (previous by-size sorting code didn't check attributes at all, taking whatever was found in the size field)

FeralChild64 added the enhancement label

FeralChild64 requested review from johnnovak, kcgen and shermp

March 26, 2023 20:37

FeralChild64 self-assigned this

FeralChild64 force-pushed the fc/tree-1 branch from b42b9dd to 5f4f239 Compare

March 26, 2023 20:42

kcgen reviewed

View reviewed changes

src/dos/program_tree.cpp Outdated Show resolved Hide resolved

kcgen reviewed

View reviewed changes

src/dos/program_tree.cpp Outdated Show resolved Hide resolved

kcgen reviewed

View reviewed changes

src/dos/program_tree.cpp Outdated Show resolved Hide resolved

kcgen reviewed

View reviewed changes

src/dos/program_tree.h Outdated Show resolved Hide resolved

kcgen reviewed

View reviewed changes

src/dos/program_tree.h Outdated Show resolved Hide resolved

kcgen reviewed

View reviewed changes

include/dos_system.h Outdated Show resolved Hide resolved

kcgen reviewed

View reviewed changes

src/dos/dos_files.cpp Show resolved Hide resolved

kcgen reviewed

View reviewed changes

src/dos/program_more_output.cpp Show resolved Hide resolved

kcgen reviewed

View reviewed changes

src/dos/program_tree.cpp Show resolved Hide resolved

Member

kcgen commented Mar 27, 2023

Just wanted to confirm that it's running on my side, and passing UBSAN and ASAN. Just some minor comments.

FeralChild64 force-pushed the fc/tree-1 branch from 5f4f239 to 2690c4e Compare

March 27, 2023 20:07


          Implement TREE.COM command

1a6ba20

FeralChild64 force-pushed the fc/tree-1 branch from 2690c4e to 1a6ba20 Compare

March 27, 2023 20:09

FeralChild64 added 2 commits

March 27, 2023 22:19


          Make 'AddMessages' methods static

87ba103


          Improve union member naming

c1bc96f

FeralChild64 requested a review from kcgen

March 27, 2023 20:34

kcgen approved these changes

View reviewed changes

Member

kcgen left a comment

This is working great, @FeralChild64!
Looking forward to having TREE available (I already use it a lot on the Linux side), and having it tied into more is a real treat!

Member

kcgen commented Mar 28, 2023

All comments addressed and tests passing; merging.

kcgen merged commit d0e04da into main

58 checks passed

FeralChild64 deleted the fc/tree-1 branch

March 29, 2023 08:18

Grounded0 mentioned this pull request

DOSBox Staging 0.81 release steering ticket #3091

Closed

4 tasks

johnnovak added the DOS label

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment