Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Auto enable shell variable expansion for DOS >=7 #2378

Merged
merged 1 commit into from Apr 4, 2023
Merged

Auto enable shell variable expansion for DOS >=7 #2378

merged 1 commit into from Apr 4, 2023

Conversation

rderooy
Copy link
Collaborator

@rderooy rderooy commented Apr 4, 2023

Automatically enable shell variable expansion when DOS version is set to >= 7.0

closes #2279

kcgen
kcgen reviewed Apr 4, 2023
View reviewed changes
Copy link
Member

@kcgen kcgen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just some minor suggestions - logic all looks good, @rderooy !

src/dosbox.cpp Outdated Show resolved Hide resolved
src/shell/shell_misc.cpp Outdated Show resolved Hide resolved
@rderooy rderooy force-pushed the rdr/expand-shell-variable-1 branch from 28f07d1 to 3a0c7b8 Compare April 4, 2023 20:25
kcgen
kcgen approved these changes Apr 4, 2023
View reviewed changes
Copy link
Member

@kcgen kcgen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great to have this shell-expansion now on auto-mode, matching the DOS version. Nice PR, @rderooy 🚀

@kcgen kcgen merged commit 7ddd178 into main Apr 4, 2023
58 checks passed
@kcgen kcgen added the enhancement New feature or enhancement of existing features label Apr 4, 2023
@kcgen kcgen deleted the rdr/expand-shell-variable-1 branch April 8, 2023 01:45
@Grounded0 Grounded0 mentioned this pull request Nov 17, 2023
Closed
4 tasks
@johnnovak johnnovak added the DOS Issues related to DOS integration or DOS commands label Dec 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kcgen kcgen kcgen approved these changes

Assignees

@rderooy rderooy

Labels
DOS Issues related to DOS integration or DOS commands enhancement New feature or enhancement of existing features
Projects
0.81 Project
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Echo environment variable does not work
3 participants
@rderooy @kcgen @johnnovak