Lookup MT-32 ROMs using std::filesystem paths #2387
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I confirm this fixes my problem with MT32 ROMs not being found. |
FeralChild64
approved these changes
Apr 7, 2023
kcgen
force-pushed
the
kc/mt32-rom-load-1
branch
2 times, most recently
from
b9ac07e
to
94be7bd
Compare
|
Confirmed working on my side and passing sanitizers. |
kcgen
force-pushed
the
kc/mt32-rom-load-1
branch
from
94be7bd
to
2f52ac5
Compare
4 tasks
johnnovak
added
audio
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Just a small carry over to keep using std::filesystem paths to look up the MT-32 ROMs.