Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cleanup in cross.cpp #2447

Merged
merged 9 commits into from May 15, 2023
Merged

Cleanup in cross.cpp #2447

merged 9 commits into from May 15, 2023

Conversation

dreamer
Copy link
Member

@dreamer dreamer commented May 1, 2023 •
edited

In #2383 we started cleaning up cross.cpp by replacing old CROSS_GetPlatformConfigDir and Cross::GetPlatformConfigDir with std::filesystem returning get_platform_config_dir. This is the continuation of this work.

@dreamer dreamer added cleanup Non-functional changes that simplify, improve maintainability, or squash warnings Linux Issues related to GNU/Linux refactoring Code refactoring without any functional changes labels May 1, 2023
@dreamer dreamer self-assigned this May 1, 2023
@dreamer dreamer marked this pull request as draft May 3, 2023 22:29
@dreamer dreamer changed the title Draft: Cleanup in cross.cpp Cleanup in cross.cpp May 3, 2023
@dreamer dreamer marked this pull request as ready for review May 6, 2023 00:22
johnnovak
johnnovak approved these changes May 6, 2023
View reviewed changes
Copy link
Member

@johnnovak johnnovak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good riddance! There's no code like no code!

@kcgen kcgen self-requested a review May 9, 2023 19:27
kcgen
kcgen approved these changes May 9, 2023
View reviewed changes
Copy link
Member

@kcgen kcgen left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@dreamer - we can go ahead w/ the PR as is, and the RESOURCE.md doco update can be a follow on update (if there's anything notable).

It would at least get the code in main and exercised sooner.

@kcgen kcgen merged commit 053a36b into main May 15, 2023
64 checks passed
@kcgen kcgen deleted the po/xdg-2 branch May 16, 2023 16:43
@Grounded0 Grounded0 mentioned this pull request Nov 17, 2023
Closed
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@johnnovak johnnovak johnnovak approved these changes

@kcgen kcgen kcgen approved these changes

Assignees

@dreamer dreamer

Labels
cleanup Non-functional changes that simplify, improve maintainability, or squash warnings Linux Issues related to GNU/Linux refactoring Code refactoring without any functional changes
Projects
0.81 Project
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@dreamer @johnnovak @kcgen