Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixes for shell_misc.cpp regressions #2517

Merged
merged 2 commits into from May 23, 2023
Merged

Fixes for shell_misc.cpp regressions #2517

merged 2 commits into from May 23, 2023

Conversation

MeAreJeenius
Copy link
Contributor

@MeAreJeenius MeAreJeenius commented May 23, 2023 •
edited by kcgen

@MeAreJeenius
Copy link
Contributor Author

#2513 #2515
I recall making and fixing this bug in inital development and testing. I must have mistakenly dropped this change.
find_first_not_of -> find_first_of

#2514
Path directories without a trailing backslash weren't inserting a backslash when searching for files.
(ie. y:\dosxcopy -> y:\dos\xcopy)

@MeAreJeenius MeAreJeenius self-assigned this May 23, 2023
@kcgen
Copy link
Member

kcgen commented May 23, 2023

Thanks for the quick fix, @MeAreJeenius ! Tested and working great. Let's get this merged. (Linking: Fixes #2513. Fixes #2514. Fixes #2515)

This was linked to issues May 23, 2023
Shell handling regression crashes when calling autotype #2513
Closed
Shell handling regression when looking up PATH executables #2514
Closed
Shell handling regression in the 7th Guest (segfault) #2515
Closed
@kcgen kcgen self-requested a review May 23, 2023 12:35
@kcgen kcgen merged commit 2143e19 into dosbox-staging:main May 23, 2023
46 checks passed
@kcgen kcgen added the regression We broke something 😊 label May 29, 2023
@Grounded0 Grounded0 mentioned this pull request Nov 17, 2023
Closed
4 tasks
@johnnovak johnnovak added the DOS Issues related to DOS integration or DOS commands label Dec 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kcgen kcgen kcgen approved these changes

Assignees

@MeAreJeenius MeAreJeenius

Labels
DOS Issues related to DOS integration or DOS commands regression We broke something 😊
Projects
0.81 Project
Status: Done
Milestone
No milestone
3 participants
@MeAreJeenius @kcgen @johnnovak