Adapt to setup function additions #2563
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We can now safely go back to the original startup sequence using the normal init function container now that the execution loop is safely handling additions (and won't triggering the checked-STL crash in debug builds).
GranMinigun
approved these changes
May 31, 2023
|
Thanks for the tests, @GranMinigun. Also working here and passing regression tests w/ the mapper. Given this is impacting most builds, let's get this merged ASAP. |
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The addition of the checked STL flags (on Linux) caused crashes inside the Setup class'
ExecuteInit().The crash happens because the container that ExecuteInit is looping over gets modified (appended to) mid-iteration, which invalidates the loop iterator.
A prior attempt to avoid this moved the appended chunk to a separate container (EarlyInit), however this broke the startup sequence for the mapper.
A prior attempt to solve this also failed:
std::dequein setup but with indexed access #2557This PR is now a third attempt to handle the modified container (and avoid crashing with the checked STL) while also keeping the original mapper placement so the startup sequence/functionality is retained.