Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't emulate CDROM lag for stationary calls #2624

Merged
merged 1 commit into from Jun 21, 2023
Merged

Don't emulate CDROM lag for stationary calls #2624

merged 1 commit into from Jun 21, 2023

Conversation

kcgen
Copy link
Member

@kcgen kcgen commented Jun 21, 2023

These are calls where time is not being measured or changing.

The remaining calls (left unchanged) involve the passage of time, such as getting the current playback position as relative and absolute MSF objects.

Thanks to @0mnicydle for quickly flagging this as a regression in Dark Seek II's intro FMV sequence.

These are calls where time is not being measured or changing.

The remaining calls (left unchanged) involve the passage of
time, such as getting the current playback position as relative
and absolute MSF objects.
@kcgen kcgen added the regression We broke something 😊 label Jun 21, 2023
@kcgen kcgen self-assigned this Jun 21, 2023
@kcgen
Copy link
Member Author

kcgen commented Jun 21, 2023

Reproduced and fixed.

@kcgen kcgen merged commit c3f30c6 into main Jun 21, 2023
60 of 61 checks passed
@kcgen kcgen deleted the kc/cdrom-lag-2 branch June 21, 2023 16:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
regression We broke something 😊
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

None yet

1 participant