Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable writing command line history if entry is empty #2635

Merged
merged 1 commit into from Jun 23, 2023

Conversation

weirddan455
Copy link
Collaborator

Follow up to #2629 and #2630

Command history should be disabled if the config entry is empty. This is a regression caused by my previous PR. Added missing empty check.

Likely this just caused an erroneous warning message as it tried to create a file with the same name as the user's config directory, which will fail.

Copy link
Member

@johnnovak johnnovak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@weirddan455 I have given you write access to the dosbox-staging repo; now you should be able to create your own branches with the wd/ prefix without having to fork. You should also be able to force push into them and delete your branches. Makes life so much easier! 🎉

Please pay attention to the wd/ prefix — that must be present in branch names created by you.

Congratulations! 🎉 🍻

Merging this now, then you can try out your new powers in your next PR 😎

@johnnovak johnnovak merged commit 6abbacb into dosbox-staging:main Jun 23, 2023
35 checks passed
@johnnovak johnnovak added the bug Something isn't working label Jun 23, 2023
@weirddan455 weirddan455 deleted the history_bug branch June 24, 2023 00:27
@johnnovak johnnovak added the DOS Issues related to DOS integration or DOS commands label Dec 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working DOS Issues related to DOS integration or DOS commands
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

None yet

2 participants