Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix mouse movement limitation regression in some games #2648

Merged
merged 1 commit into from Jun 27, 2023

Conversation

FeralChild64
Copy link
Collaborator

@FeralChild64 FeralChild64 commented Jun 26, 2023

The recent mouse cursor range fix for text modes over 80 columns went too far - it seems some graphic modes below 640 pixels width really need maximum x set to 639, or mouse cursor in some games won’t work correctly.

@FeralChild64 FeralChild64 added bug Something isn't working regression We broke something 😊 labels Jun 26, 2023
@FeralChild64 FeralChild64 self-assigned this Jun 26, 2023
@FeralChild64 FeralChild64 marked this pull request as ready for review June 26, 2023 16:04
@kcgen
Copy link
Member

kcgen commented Jun 26, 2023

I'm guessing VGA tweaked modes should be OK, if they were previously OK (Scorched Earth's various modes make good test-cases).

Approving; just waiting for feedback that this fixes it.

@kcgen
Copy link
Member

kcgen commented Jun 27, 2023

Comments addressed and fixed; merging. Thanks for the quick fix, @FeralChild64 !

@kcgen kcgen merged commit cbf7417 into main Jun 27, 2023
52 checks passed
@FeralChild64 FeralChild64 deleted the fc/mouse-max-x-fix-1 branch July 5, 2023 17:18
@johnnovak johnnovak added the input handling Issues related to handling any input (keyboard, mouse, joystick & game controllers) label Dec 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working input handling Issues related to handling any input (keyboard, mouse, joystick & game controllers) regression We broke something 😊
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

None yet

3 participants