Fix image capture indices always starting from 1 #2656
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A last-minute improvement to the capture PR to create the capture directory on-demand (lazily) introduced a regression: the image capture indices now always start from 1, potentially overwriting existing images. This was a result of the image capturers running asynchronously in separate threads combined with the lazy/deferred capture directory creation and highest index lookup approach.
This is the fix for that, plus also for a potential race condition when determining the current highest capture indices.