Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Un-deprecate the per-SoundFont volume scaling #2677

Merged
merged 3 commits into from Jul 15, 2023
Merged

Un-deprecate the per-SoundFont volume scaling #2677

merged 3 commits into from Jul 15, 2023

Conversation

johnnovak
Copy link
Member

@johnnovak johnnovak commented Jul 12, 2023 •
edited

Fixes #2616 plus other small cleanups, fixes, enhancements—as usual.

Review per commit.

@johnnovak johnnovak self-assigned this Jul 12, 2023
@johnnovak johnnovak added audio Audio related issues or enhancements enhancement New feature or enhancement of existing features labels Jul 12, 2023
weirddan455
weirddan455 reviewed Jul 12, 2023
View reviewed changes
Copy link
Collaborator

@weirddan455 weirddan455 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not really familiar with the FluidSynth code but this all looks fine as far as I can tell.

@johnnovak
Copy link
Member Author

Someone please give me a tick? @FeralChild64 ?

@FeralChild64
Copy link
Collaborator

I have just one remark (actually a pre-existing problem).

@johnnovak johnnovak merged commit 0184ef3 into main Jul 15, 2023
52 checks passed
@kcgen kcgen deleted the jn/restore-soundfont-level branch August 1, 2023 23:05
@Grounded0 Grounded0 mentioned this pull request Nov 17, 2023
Closed
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@weirddan455 weirddan455 weirddan455 left review comments

@Kappa971 Kappa971 Kappa971 left review comments

@FeralChild64 FeralChild64 FeralChild64 approved these changes

Assignees

@johnnovak johnnovak

Labels
audio Audio related issues or enhancements enhancement New feature or enhancement of existing features
Projects
0.81 Project
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Reinstate the SoundFont level volume setting
4 participants
@johnnovak @FeralChild64 @weirddan455 @Kappa971