Fix "-fullscreen" argument on Wayland #2688
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Initalizing the window to fullscreen was being handled twice: Once in GUI_StartUp and then later in sdlmain. Removed the redundant handling.
johnnovak
reviewed
Jul 17, 2023
|
Works fine on macOS. Can you check Windows please?
So, overall, it's better but make sure Windows still works. |
|
Tested in Windows. It works and actually looks a bit smoother. In current main, you can see it create an empty window, sit there for second, and then go fullscreen. With this patch, it loads directly to fullscreen without seeing that awkward transition. |
johnnovak
added
enhancement
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2671
Initializing the window to fullscreen was being handled twice: Once in GUI_StartUp and then later in sdlmain.
Removed the redundant handling.