Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make MOVE and SUBST external commands #2691

Merged
merged 2 commits into from Jul 21, 2023
Merged

Make MOVE and SUBST external commands #2691

merged 2 commits into from Jul 21, 2023

Conversation

weirddan455
Copy link
Collaborator

Fixes #2666 #2667

As discussed, this is just re-using the existing code from shell_cmds.cpp

@weirddan455 weirddan455 linked an issue Jul 18, 2023 that may be closed by this pull request
SUBST must be an external command #2667
Closed
2 tasks
johnnovak
johnnovak reviewed Jul 18, 2023
View reviewed changes
src/dos/program_move.cpp Outdated Show resolved Hide resolved
johnnovak
johnnovak reviewed Jul 18, 2023
View reviewed changes
src/dos/program_move.h Outdated Show resolved Hide resolved
@FeralChild64 FeralChild64 added the bug Something isn't working label Jul 19, 2023
johnnovak
johnnovak approved these changes Jul 21, 2023
View reviewed changes
Copy link
Member

@johnnovak johnnovak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @weirddan455 , approved & merging. As discussed with @shermp , the MSYS2 fiasco should not hold up merging PRs.

@johnnovak johnnovak merged commit b71d4ff into main Jul 21, 2023
47 of 52 checks passed
@weirddan455 weirddan455 deleted the wd/move branch July 21, 2023 13:37
@johnnovak johnnovak added enhancement New feature or enhancement of existing features and removed bug Something isn't working labels Nov 13, 2023
@Grounded0 Grounded0 mentioned this pull request Nov 17, 2023
Closed
4 tasks
@johnnovak johnnovak added the DOS Issues related to DOS integration or DOS commands label Dec 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@johnnovak johnnovak johnnovak approved these changes

Assignees

@weirddan455 weirddan455

Labels
DOS Issues related to DOS integration or DOS commands enhancement New feature or enhancement of existing features
Projects
0.81 Project
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

SUBST must be an external command MOVE must be an external command
3 participants
@weirddan455 @johnnovak @FeralChild64