Fix deactivation of queued joystick axis movement #2713
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When mapping a host keyboard button to a vitual joystick axis, the prior logic would allow a queue of the same event (ie: holding a given direction) to ignore deactivation of the event (ie: release of the direction). This change now zeroes the queued action and deactivates when requested. Tested with: - Host analog stick driving the axes (native control) - Host D-pad mapped to the analog axes - Keypad up/down/left/right mapped to analog axes
johnnovak
reviewed
Aug 2, 2023
johnnovak
approved these changes
Aug 2, 2023
4 tasks
johnnovak
added
the
input handling
10 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When mapping a host keyboard button to a virtual joystick axis, the prior logic would allow a queue of the same event (ie: holding a given direction) to ignore deactivation of the event (ie: release of the direction).
This change now zeroes the queued action and deactivates when requested.
joytest.zip was used with: